fix(sharing): Use link_defaultExpDays for default expiration in web UI#58343
Open
fix(sharing): Use link_defaultExpDays for default expiration in web UI#58343
Conversation
nfebe
requested review from
ArtificialOwl,
artonge,
icewind1991,
sorbaugh and
susnux
and removed request for
a team
Member
|
Thank you for this PR! This partially works. The default date is now correct: But the maximum date is the same as the default in the UI. So even if I think this can be addressed in |
Member
|
IMO this can be backported to 31, 32 and 33. |
nfebe
force-pushed
the
fix/link-default-exp-days
branch
2 times, most recently
from
f5a36d5 to
531beef
Compare
nfebe
force-pushed
the
fix/link-default-exp-days
branch
from
531beef to
8bffd6a
Compare
Contributor
Author
|
/compile / |
The link_defaultExpDays config was only used in the backend share validation but never exposed to the frontend, making it impossible to set a default expiration date different from the maximum. Signed-off-by: nfebe <fenn25.fn@gmail.com>
The maxExpirationDateEnforced was using defaultExpirationDate which now returns the default date (linkDefaultExpDays) instead of the maximum (shareapi_expire_after_n_days), preventing users from picking dates between the default and maximum. Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/link-default-exp-days
branch
from
dfdf282 to
f1ff7d7
Compare
Contributor
Author
|
/compile / |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
julien-nc
approved these changes
Feb 25, 2026
Member
julien-nc
left a comment
julien-nc
left a comment
There was a problem hiding this comment.
The default date and the max date are now independent and effective in the UI 👍
Contributor
Author
|
/backport to stable33 |
Contributor
Author
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link_defaultExpDays config was only used in the backend share validation but never exposed to the frontend, making it impossible to set a default expiration date different from the maximum.