feat(config): Allow defining config.php permissions after write#58384
Merged
nickvergessen merged 1 commit intomasterfrom Feb 23, 2026
Merged
feat(config): Allow defining config.php permissions after write#58384nickvergessen merged 1 commit intomasterfrom
nickvergessen merged 1 commit intomasterfrom
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
come-nc,
icewind1991,
leftybournes and
salmart-dev
and removed request for
a team
6 tasks
nickvergessen
commented
Feb 17, 2026
Comment on lines
+2617
to
+2621
| * config.php file mode in octal notation. | ||
| * | ||
| * Defaults to ``0640`` (writable by user, readable by group). | ||
| */ | ||
| 'configfilemode' => 0640, |
Member
Author
There was a problem hiding this comment.
Naming and format is a copy of logfilemode for the log file, so I'd rather stick with that.
provokateurin
approved these changes
Feb 23, 2026
Altahrim
approved these changes
Feb 23, 2026
susnux
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
3. to review, feature component)stable32)