fix: user count frontend version#58398
Conversation
Signed-off-by: csilva1-eng <christophersilva656@gmail.com>
csilva1-eng
requested review from
skjnldsv,
susnux and
szaimen
and removed request for
a team
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
works for now but will break with Vue 3 migration (component then only allows numeric values)
|
/backport to stable33 |
|
/backport to stable32 |
| const userCount = computed(() => { | ||
| const count = store.getters.getUserCount | ||
|
|
||
| return count >= 999 ? '999+' : 0 |
There was a problem hiding this comment.
Mistake on this line. Meant to be
return count >= 999 ? '999+' : count
There was a problem hiding this comment.
| return count >= 999 ? '999+' : 0 | |
| return count >= 999 ? '999+' : count |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
4 participants
Summary
Saw that the previous pull request to this had an issue with working in the backend. I changed the line in the frontend as suggested to avoid that issue. This is my first ever open source contribution! Apologies in advance for any mistakes I may have made.
Checklist
3. to review, feature component)stable32)