test(DbHandler): make sure auto-increment is reset in between tests#58501
Draft
joshtrichards wants to merge 2 commits intomasterfrom
Draft
test(DbHandler): make sure auto-increment is reset in between tests#58501joshtrichards wants to merge 2 commits intomasterfrom
joshtrichards wants to merge 2 commits intomasterfrom
Conversation
DELETE doesn't reset auto-increment; TRUNCATE does. Also probably faster. Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DELETE doesn't reset auto-increment; TRUNCATE does. Also probably faster.
Summary
We're doing DELETE rather than TRUNCATE in tearDown(). The former does not reset auto-increment/identity columns on MySQL. Random failures like below with MySQL may be because of this.
Would not be caught in setUp() by the assert on select() because that's based on count not id.
P.S. Though I'm discovering from looking at DBAL's code that even though DBAL implements getTruncateTableSQL() for all supported databases, it merely does a DELETE in SQLite... so we may need a wrapper function or something to truly take care of this universally across our tests (since I suspect we have other tests want to do real TRUNCATE/equivalents in).
TODO
Checklist
3. to review, feature component)stable32)