fix(encryption): Improve type strictness on decryption check#58525
Merged
AndyScherzinger merged 1 commit intomasterfrom Feb 26, 2026
Merged
fix(encryption): Improve type strictness on decryption check#58525AndyScherzinger merged 1 commit intomasterfrom
AndyScherzinger merged 1 commit intomasterfrom
Conversation
Otherwise decrypting a falsy value like '0' would be seen as a decryption failure. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
added
3. to review
come-nc
requested review from
leftybournes,
nfebe,
salmart-dev and
sorbaugh
and removed request for
a team
kesselb
approved these changes
Feb 26, 2026
AndyScherzinger
approved these changes
Feb 26, 2026
AndyScherzinger
deleted the
fix/fix-decryption-failure-false-positive
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve type strictness on decryption check. Otherwise decrypting a falsy value like '0' would be seen as a decryption failure.
Checklist
3. to review, feature component)stable32)