fix(Session): Prevent immediate token invalidation#58555
Open
fix(Session): Prevent immediate token invalidation#58555
Conversation
solracsf
requested review from
ArtificialOwl and
icewind1991
and removed request for
a team
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
preventTokenInvalidation
branch
from
3c38418 to
f49ecf2
Compare
8 tasks
come-nc
reviewed
Mar 2, 2026
| if ($this->manager->checkPassword($tokenLoginName, $pwd) === false) { | ||
| // If the decrypted password is empty or not a valid local password, | ||
| // but the user exists and is enabled, we DO NOT permanently invalidate the token. | ||
| if (empty($pwd) || $this->manager->get($tokenLoginName) !== null) { |
Contributor
There was a problem hiding this comment.
Was this supposed to be && ?
Otherwise any existing user fills the condition so tokens will not get invalidated anymore apart from deleted users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #56412 where app passwords (device tokens) generated via
occ user:auth-tokens:add, or used in SSO/LDAP environments, are unexpectedly and permanently invalidated exactly 5 minutes after creation.This correctly logs the user out for that specific session without permanently destroying valid tokens generated by admins or used by SSO users. Legitimate password changes or user deletions will still trigger the expected permanent invalidation.
Checklist
3. to review, feature component)stable32)