Skip to content

refactor: Remove old Share backend#58593

Merged
provokateurin merged 2 commits intomasterfrom
carl/share-spring-cleaning
Mar 10, 2026
Merged

refactor: Remove old Share backend#58593
provokateurin merged 2 commits intomasterfrom
carl/share-spring-cleaning

Conversation

@CarlSchwan
Copy link
Copy Markdown
Member

@CarlSchwan CarlSchwan commented Feb 26, 2026

Summary

This has been implicitely deprecated for a while with Share20 containing the new implementation.

The only use was to determine whether remote sharing and resharing were enabled or not, which we can do much more easily.

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan CarlSchwan force-pushed the carl/share-spring-cleaning branch 2 times, most recently from 238b9d0 to 7607293 Compare February 26, 2026 16:18
@CarlSchwan CarlSchwan marked this pull request as ready for review February 26, 2026 16:18
@CarlSchwan CarlSchwan requested a review from a team as a code owner February 26, 2026 16:18
@CarlSchwan CarlSchwan requested review from Altahrim, leftybournes, salmart-dev and sorbaugh and removed request for a team February 26, 2026 16:18
@CarlSchwan CarlSchwan force-pushed the carl/share-spring-cleaning branch 2 times, most recently from b8ac539 to e60036b Compare February 26, 2026 16:42
@nickvergessen nickvergessen added the pending documentation This pull request needs an associated documentation update label Feb 26, 2026
@CarlSchwan CarlSchwan added this to the Nextcloud 34 milestone Feb 26, 2026
@CarlSchwan CarlSchwan added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Feb 26, 2026
@CarlSchwan CarlSchwan self-assigned this Feb 26, 2026
@CarlSchwan CarlSchwan mentioned this pull request Feb 26, 2026
7 tasks
@CarlSchwan
Copy link
Copy Markdown
Member Author

Copy link
Copy Markdown
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹

@CarlSchwan
Copy link
Copy Markdown
Member Author

ping

@provokateurin provokateurin enabled auto-merge March 8, 2026 14:34
@CarlSchwan CarlSchwan force-pushed the carl/share-spring-cleaning branch 2 times, most recently from 3e0dfd2 to 8053f9b Compare March 9, 2026 11:30
@CarlSchwan CarlSchwan requested a review from provokateurin March 9, 2026 11:31
This has been implicitely deprecated for a while with Share20 containing
the new implementation.

The only use was to determine whether remote sharing was enabled or not,
which we can do much more easily.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the carl/share-spring-cleaning branch 3 times, most recently from 6bd991f to b820dc5 Compare March 10, 2026 10:01
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the carl/share-spring-cleaning branch from b820dc5 to 7fa4471 Compare March 10, 2026 10:40
@provokateurin provokateurin merged commit 810caa3 into master Mar 10, 2026
208 of 215 checks passed
@provokateurin provokateurin deleted the carl/share-spring-cleaning branch March 10, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants