Skip to content

feat(UserPlugin): Include teams in group search#58603

Merged
AndyScherzinger merged 1 commit intonextcloud:masterfrom
pymnh:feat/extend-group-search-to-teams
Mar 9, 2026
Merged

feat(UserPlugin): Include teams in group search#58603
AndyScherzinger merged 1 commit intonextcloud:masterfrom
pymnh:feat/extend-group-search-to-teams

Conversation

@pymnh
Copy link
Copy Markdown
Contributor

@pymnh pymnh commented Feb 26, 2026

Summary

  • Extend UserPlugin: If autocompletion is enabled for groups and the teams interface is available, also search in teams.

Changes:

  • Update the private getTeamsForUser() function to return a dict (user id => display name) instead of only user id
  • Add the updated getTeamsForUser() and the preexisting hasTeamSupport() to the public ITeamManager class
  • Previously there was only one usage of the private getTeamsForUser() -> Adjust it to the new return value (dict instead of array), use the public ITeamInterface instead of TeamInterface and adjust the mocks for testing.

TODO

  • There does not seem to be unit tests for UserPlugin. I am not sure if I should add one to test the behaviour, if so I would need a bit of guidance

Checklist

AI

I used AI to adjust the test mocks and comments 🙂

@pymnh pymnh force-pushed the feat/extend-group-search-to-teams branch from 9f5358a to 403a7be Compare February 26, 2026 23:38
@pymnh pymnh marked this pull request as ready for review February 26, 2026 23:39
@pymnh pymnh requested a review from a team as a code owner February 26, 2026 23:39
@pymnh pymnh requested review from Altahrim, leftybournes, nfebe and salmart-dev and removed request for a team February 26, 2026 23:39
@pymnh
Copy link
Copy Markdown
Contributor Author

pymnh commented Feb 26, 2026

Hi @mejo- , maybe you can have a look at my changes, since this also addresses the usability of the collectives app?

@pymnh pymnh force-pushed the feat/extend-group-search-to-teams branch from 403a7be to 4713684 Compare February 26, 2026 23:48
@pymnh
Copy link
Copy Markdown
Contributor Author

pymnh commented Feb 27, 2026

Had some trouble setting up cs-fixer and rector with latest Fedora (PHP 8.4), should pass the CI now, I believe. 🙈

@pymnh pymnh force-pushed the feat/extend-group-search-to-teams branch from 8e0d92f to 6a9c3fc Compare February 27, 2026 21:06
@mejo-
Copy link
Copy Markdown
Member

mejo- commented Mar 1, 2026

@pymnh can you squash the two commits so "Block unconventional commits" doesn't fail?

@pymnh pymnh force-pushed the feat/extend-group-search-to-teams branch from 6a9c3fc to f6cb2ce Compare March 1, 2026 17:23
@pymnh
Copy link
Copy Markdown
Contributor Author

pymnh commented Mar 1, 2026

@pymnh can you squash the two commits so "Block unconventional commits" doesn't fail?

done

@pymnh pymnh force-pushed the feat/extend-group-search-to-teams branch 2 times, most recently from 04be612 to ece059d Compare March 4, 2026 16:12
Copy link
Copy Markdown
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks for the contribution @pymnh 💙

Tested and works as expected.

@mejo-
Copy link
Copy Markdown
Member

mejo- commented Mar 5, 2026

@come-nc @CarlSchwan needs a force-merge as some CI jobs didn't run due to the PR being made from a fork.

@mejo- mejo- self-assigned this Mar 5, 2026
@come-nc
Copy link
Copy Markdown
Contributor

come-nc commented Mar 5, 2026

I do not have the powers to force-merge, but I second that.

Signed-off-by: Peymaneh <peymaneh@posteo.net>
@pymnh pymnh force-pushed the feat/extend-group-search-to-teams branch from ece059d to 3985555 Compare March 9, 2026 12:51
@mejo- mejo- added enhancement 3. to review Waiting for reviews feature: circles Related to circles labels Mar 9, 2026
@AndyScherzinger AndyScherzinger merged commit 56eaf1d into nextcloud:master Mar 9, 2026
161 of 164 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Autocompletion for fellow team members and known users

5 participants