refactor(admin_audit): migrate to IAppConfig#58750
Open
joshtrichards wants to merge 8 commits intomasterfrom
Open
refactor(admin_audit): migrate to IAppConfig#58750joshtrichards wants to merge 8 commits intomasterfrom
joshtrichards wants to merge 8 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
technical debt
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
ArtificialOwl,
come-nc and
leftybournes
and removed request for
a team
come-nc
reviewed
Mar 8, 2026
Comment on lines
84
to
86
| $context->registerService(IAuditLogger::class, function (ContainerInterface $c) { | ||
| return new AuditLogger($c->get(ILogFactory::class), $c->get(IConfig::class)); | ||
| return new AuditLogger($c->get(ILogFactory::class), $c->get(IAppConfig::class), $c->get(IConfig::class)); | ||
| }); |
Contributor
There was a problem hiding this comment.
Could simply be an alias I believe?
Member
Author
There was a problem hiding this comment.
Still need the factory/closure to create the IAuditLogger service AFAIK. In this case the factory/closure is creating the IAuditLogger:class as a service, by returning an AuditLogger.
Just the interface IAuditLogger is being published as the service directly.
I guess we could do both, but I don't see any reason to register the service against both the implementation and the interface. Existing behavior too. ;-)
Contributor
There was a problem hiding this comment.
The DI is able to magically build classes based on their attributes.
So you can just do
$context->registerServiceAlias(IAuditLogger::class, AuditLogger::class);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🧹
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)