fix: increase bucket_name column length to 63 chars#58758
fix: increase bucket_name column length to 63 chars#58758boris324 wants to merge 1 commit intonextcloud:masterfrom
Conversation
| </NcFormBox> | ||
| <NcRadioGroup | ||
| v-model="store.userConfig.default_view" | ||
| name="default_view" |
There was a problem hiding this comment.
| name="default_view" |
I guess this is a mistake?
There was a problem hiding this comment.
Yeah, that was from another branch that got mixed in by mistake. Removed it now, force pushed with only the bucket_name migration commit.
AWS allows bucket names up to 63 characters per their naming rules, but the bucket_name column in oc_preview_locations was varchar(40). This updates the initial migration to use length 63 for fresh installs and adds a new migration to alter the column for existing installs. Fixes: nextcloud#58755 Signed-off-by: boris324 <boris324@users.noreply.github.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8ea6b7e to
9c14810
Compare
|
Let me fix it
Thank you for your help.
…On Mon, Mar 9, 2026 at 7:50 PM Côme Chilliet ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In apps/files/src/components/FilesAppSettings/FilesAppSettingsGeneral.vue
<#58758 (comment)>:
> @@ -37,6 +37,7 @@ const store = useUserConfigStore()
</NcFormBox>
<NcRadioGroup
v-model="store.userConfig.default_view"
+ name="default_view"
⬇️ Suggested change
- name="default_view"
I guess this is a mistake?
—
Reply to this email directly, view it on GitHub
<#58758 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANL5E4B5L4FHMQ7KQ75DRU34P2OV5AVCNFSM6AAAAACWJYUYDWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSMJUGUZDQMZVGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
bucket_namecolumn length inoc_preview_locationsfromvarchar(40)tovarchar(63)Changes
core/Migrations/Version33000Date20250819110529.php- Updated initial schema to definebucket_namewith length 63 instead of 40core/Migrations/Version33000Date20260306120000.php- New migration that increases thebucket_namecolumn length to 63 for existing installationsFixes #58755
Test plan
oc_preview_locations.bucket_namecolumn is created asvarchar(63)varchar(40): verify the new migration alters the column tovarchar(63)🤖 Generated with Claude Code