Multiple cleanups in OCP/Utils and OC_Utils#58806
Open
CarlSchwan wants to merge 5 commits intomasterfrom
Open
Conversation
Add a new IUrlGenerator::linkToRemote and replace usage of the old API with the new one. Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
The underlying OC_Utils methods are already deprecated Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/utils-cleanup
branch
from
48b6584 to
e61fdd6
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/utils-cleanup
branch
from
e61fdd6 to
729b59a
Compare
Used like this in many places Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/utils-cleanup
branch
from
729b59a to
56066b9
Compare
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
salmart-dev
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See individual commits, but remove deprecated stuff in OC_Utils and deprecate more stuff in OCP\Util
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)