Skip to content

refactor: remove long deprecated IServerContainer methods#58808

Merged
come-nc merged 2 commits intomasterfrom
carl/remove-many-get-server
Mar 10, 2026
Merged

refactor: remove long deprecated IServerContainer methods#58808
come-nc merged 2 commits intomasterfrom
carl/remove-many-get-server

Conversation

@CarlSchwan
Copy link
Copy Markdown
Member

@CarlSchwan CarlSchwan commented Mar 9, 2026

  • Resolves: #

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan CarlSchwan force-pushed the carl/remove-many-get-server branch from 62ca44b to fa8c1fa Compare March 9, 2026 15:36
@CarlSchwan
refactor: remove long deprecated IServerContainer methods
39c14c3 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the carl/remove-many-get-server branch from fa8c1fa to 39c14c3 Compare March 10, 2026 09:36
@CarlSchwan CarlSchwan marked this pull request as ready for review March 10, 2026 09:36
@CarlSchwan CarlSchwan requested a review from a team as a code owner March 10, 2026 09:36
@CarlSchwan CarlSchwan self-assigned this Mar 10, 2026
@CarlSchwan CarlSchwan requested review from Altahrim, leftybournes, nfebe and salmart-dev and removed request for a team March 10, 2026 09:36
@CarlSchwan CarlSchwan added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Mar 10, 2026
provokateurin
provokateurin approved these changes Mar 10, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 🧹

@come-nc
Copy link
Copy Markdown
Contributor

come-nc commented Mar 10, 2026

Fatal error: Call to undefined method OC\Server::getMemCacheFactory()

From integration tests.

@come-nc come-nc force-pushed the carl/remove-many-get-server branch 2 times, most recently from a53dac2 to 245e62d Compare March 10, 2026 11:45
@come-nc
chore: Run rector on integration bootstrap code
082664c 
This avoids integration PHP code to use deprecated method and crash when
 we remove them.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the carl/remove-many-get-server branch from 245e62d to 082664c Compare March 10, 2026 13:16
@come-nc come-nc merged commit 17ef1db into master Mar 10, 2026
208 of 212 checks passed
@come-nc come-nc deleted the carl/remove-many-get-server branch March 10, 2026 14:00
@nabim777 nabim777 mentioned this pull request Mar 11, 2026
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@provokateurin provokateurin provokateurin approved these changes

@come-nc come-nc come-nc approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review Waiting for reviews technical debt 🧱 🤔🚀

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CarlSchwan @come-nc @provokateurin