refactor(cache-storage): Make Storage and StorageGlobal psalm strict#58826
Merged
refactor(cache-storage): Make Storage and StorageGlobal psalm strict#58826
Conversation
CarlSchwan
requested review from
Altahrim,
icewind1991 and
sorbaugh
and removed request for
a team
provokateurin
requested changes
Mar 10, 2026
CarlSchwan
force-pushed
the
carl/code-cleaning-storage-cache
branch
from
5dff0f5 to
70d467e
Compare
provokateurin
approved these changes
Mar 10, 2026
come-nc
approved these changes
Mar 10, 2026
| private static $globalCache = null; | ||
| private $storageId; | ||
| private $numericId; | ||
| private static ?StorageGlobal $globalCache = null; |
Contributor
There was a problem hiding this comment.
Thought we said no static 😈
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/code-cleaning-storage-cache
branch
from
70d467e to
c513e93
Compare
Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/code-cleaning-storage-cache
branch
from
c513e93 to
783e2ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)