fix: #58828 occ group:list -i displays user's name too#58829
fix: #58828 occ group:list -i displays user's name too#58829smarinier wants to merge 2 commits intonextcloud:masterfrom
Conversation
Signed-off-by: Sebastien Marinier <seb@smarinier.net>
core/Command/Group/ListCommand.php
Outdated
| return array_map(function ($userId) use ($addInfo) { | ||
| $user = $addInfo ? $this->userManager->get($userId) : null; | ||
| return (string)$userId . ($user ? ': ' . $user->getDisplayName() : ''); |
There was a problem hiding this comment.
| return array_map(function ($userId) use ($addInfo) { | |
| $user = $addInfo ? $this->userManager->get($userId) : null; | |
| return (string)$userId . ($user ? ': ' . $user->getDisplayName() : ''); | |
| $users = $group->getUsers(); | |
| return array_map(function (IUser $user) use ($addInfo): string { | |
| return $user->getUID() . ($addInfo ? ': ' . $user->getDisplayName() : ''); |
Should be a lot more efficient
Signed-off-by: Sebastien Marinier <seb@smarinier.net>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
occ group:list displays uids only. That is useless with generated uids (sso).
Using -i allow to have user's name too on list print
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)