Skip to content

refactor(view): getLocalFile path handling#58854

Merged
CarlSchwan merged 3 commits intomasterfrom
jtr/refactor-View-getLocalFile
Mar 12, 2026
Merged

refactor(view): getLocalFile path handling#58854
CarlSchwan merged 3 commits intomasterfrom
jtr/refactor-View-getLocalFile

Conversation

@joshtrichards
Copy link
Copy Markdown
Member

@joshtrichards joshtrichards commented Mar 10, 2026

  • Resolves: #

Summary

🧹
The previous getLocalFile() logic worked, but used less-intuitive parent extraction and duplicated resolution steps. It now uses View's resolvePath() rather than duplicating logic.

Also adds type hinting for and clarifies resolvePath and getAbsolutePath() contracts.

This is primarily a readability/maintainability refactor plus doc clarity.

TODO

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added feature: filesystem ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Mar 10, 2026
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Mar 11, 2026
@joshtrichards joshtrichards marked this pull request as ready for review March 11, 2026 02:19
@joshtrichards joshtrichards requested a review from a team as a code owner March 11, 2026 02:19
@joshtrichards joshtrichards requested review from artonge, leftybournes, nfebe and salmart-dev and removed request for a team March 11, 2026 02:19
@joshtrichards joshtrichards changed the title refactor(view): getLocalFile path handling and clarify resolvePath contract refactor(view): getLocalFile path handling Mar 11, 2026
@joshtrichards joshtrichards added this to the Nextcloud 34 milestone Mar 11, 2026
@CarlSchwan CarlSchwan merged commit 83956e9 into master Mar 12, 2026
197 checks passed
@CarlSchwan CarlSchwan deleted the jtr/refactor-View-getLocalFile branch March 12, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: filesystem ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants