feat(core): cast valid booleans when setting system configs

[skjnldsv]

I think we could be smarter with primitive values like those 🙈

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

• The content of this PR was partly or fully generated using AI

[come-nc]

But that would mean when setting a configuration to "false" or "true" it would automagically decide that it’s a boolean even if we indicated type string?
That seems dangerous to me.
Maybe output a warning but do not change the type on the fly.

Otherwise how would one set a configuration to the string "true", it would not be possible anymore?

[skjnldsv]

But that would mean when setting a configuration to "false" or "true" it would automagically decide that it’s a boolean even if we indicated type string? That seems dangerous to me. Maybe output a warning but do not change the type on the fly.

Otherwise how would one set a configuration to the string "true", it would not be possible anymore?

We do not have any
https://github.com/nextcloud/server/blob/bb4c9ecc0e316782227570257856891995b1e369/config/config.sample.php

[artonge]

I just saw that Côme had the same comment. Given your answer, I say let's go!

[come-nc]

But that would mean when setting a configuration to "false" or "true" it would automagically decide that it’s a boolean even if we indicated type string? That seems dangerous to me. Maybe output a warning but do not change the type on the fly.
Otherwise how would one set a configuration to the string "true", it would not be possible anymore?

We do not have any https://github.com/nextcloud/server/blob/bb4c9ecc0e316782227570257856891995b1e369/config/config.sample.php

We do not have any what? String in the configuration?

If the dbuser is named "true" or it’s the smtp password or whatever, now the command will silently set it to a boolean despite being called with --type string. That’s misleading. It should at the very least output a warning when the type was explicitly set and it does an auto-conversion.
I’m fine with guessing the type when --type was not passed, but silently not respecting an explicit option is bad behavior.