chore(.htaccess): 🧹 drop no-op QSA flag from RewriteRules#58870
Merged
chore(.htaccess): 🧹 drop no-op QSA flag from RewriteRules#58870
Conversation
- For Apache `RewriteRule`, if the substitution (right side) has no `?` query part, the original query string is already preserved by default. - So `QSA` adds nothing in these rules. Note for the future: QSA will be needed if we ever add a query string on the right (substitution) side. We don't currently so this is just noise in the htaccess rules. Signed-off-by: Josh <josh.t.richards@gmail.com>
CarlSchwan
approved these changes
Mar 12, 2026
Altahrim
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #Summary
🧹
RewriteRule, if the substitution (right side) has no?query part, the original query string is already preserved by default.QSAadds nothing in these rules.Note for the future: QSA will be needed if we ever add a query string on the right (substitution) side. We don't currently so this is just noise in the htaccess rules.
https://httpd.apache.org/docs/trunk/rewrite/flags.html#flag_qsa
https://httpd.apache.org/docs/current/mod/mod_rewrite.html#rewriterule
P.S. In case it comes up, no current counterpart adjustments need to be made to our Nginx configuration at this time.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)