Skip to content

fix: call log normalizer by reference#58883

Closed
ChristophWurst wants to merge 1 commit intomasterfrom
fix/log-normalizer-call-by-reference
Closed

fix: call log normalizer by reference#58883
ChristophWurst wants to merge 1 commit intomasterfrom
fix/log-normalizer-call-by-reference

Conversation

@ChristophWurst
Copy link
Copy Markdown
Member

  • Resolves: #

Summary

Apparently the function reference syntax doesn't allow PHP to pass by ref.

  1. Nextcloud\\LogNormalizer\\Normalizer::format(): Argument #1 ($data) must be passed by reference, value given at /nextcloud/lib/private/Log.php#162
  2. Nextcloud\\LogNormalizer\\Normalizer::format(): Argument #1 ($data) must be passed by reference, value given at /nextcloud/lib/private/Log.php#347
  3. "Nextcloud\\LogNormalizer\\Normalizer::format(): Argument #1 ($data) must be passed by reference, value given at /nextcloud/lib/private/Log.php#349

TODO

  • fix

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
@ChristophWurst ChristophWurst added this to the Nextcloud 34 milestone Mar 12, 2026
@ChristophWurst ChristophWurst self-assigned this Mar 12, 2026
@ChristophWurst ChristophWurst requested a review from a team as a code owner March 12, 2026 10:13
@ChristophWurst ChristophWurst requested review from salmart-dev and removed request for a team March 12, 2026 10:13
@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Mar 12, 2026
@ChristophWurst
Copy link
Copy Markdown
Member Author

This actually means the formatting did not happen: https://3v4l.org/b1KoE#vnull

@ChristophWurst
Copy link
Copy Markdown
Member Author

Nevermind, my 3rdparty was outdated.

Ref #55990 for the original bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant