chore(workflows): remove cypress cloud#58903
Conversation
miaulalala
requested review from
ArtificialOwl,
artonge,
Copilot,
icewind1991,
leftybournes and
skjnldsv
and removed request for
a team
and allow regular cypress tests to run on forks (no secret leaked) add consistent gating for changes remove empty matrix option skip performance workflow on forks without it looking like it's failing Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
chore/noid/update-workflows
branch
from
cf40a66 to
a77040f
Compare
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
There are a lot of unrelated changes. Please only remove the cypress cloud stuff and move everything else to another PR.
not unrelated, should ideally change my commit message. Making CI work reliably for contributor as well as members is the goal here, of which cypress cloud is only one part. |
|
At least split them up into separate commits with useful commit messages. If I can't understand the CI changes, I won't approve 😅 |
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Changes make sense, but its really not ideal for the commits.
It will be hard to reason about the changes later when you git blame because of missing commit message(s).
Better to split and put the changes listed in the PR description directly into the individual commit messages.
Seconded |
Changes:
autocheckers.ymlneeds: changes+if: needs.changes.outputs.src != 'false'; fixed summary condition logiccommand-pull-3rdparty.ymlpull-requests: readpermission + GitHub API step for PR metadata; simplifiedserver_refstepcypress.ymlgroup,ci-build-id,tag,CYPRESS_RECORD_KEY)files-external-sftp.ymlsudo chown -R 0777→sudo chmod -R 0777integration-dav.ymlintegration-s3-primary.ymlsleep 10before S3 health checklint-php-cs.ymlneeds: changes+if:guardlint-stylelint.ymlchangesjob viadorny/paths-filter; gatedlinton it; addedsummaryjob for branch protectionnode-test.ymlobject-storage-s3.ymlsleep 10before S3 health checkperformance.ymlif:→ cleanskippedstatus on forksphpunit-object-store-primary.yml--log-junit junit.xmlto PHPUnit runupdate-min-supported-desktop.yml${{ matrix.branches }}-prefix)Checklist
Tests (unitintegration, api and/or acceptance) are includedScreenshots before/after for front-end changesDocumentation (manuals or wiki) has been updated or is not requiredBackports requested where applicable (ex: critical bugfixes)Labels added where applicable (ex: bug/enhancement,3. to review, feature component)stable32)AI (if applicable)