feat(recent-files): allow configuring image grouping by cristianscheid · Pull Request #58908 · nextcloud/server

cristianscheid · 2026-03-13T09:56:16Z

Resolves: #

Summary

New settings have been added to the Files settings page allowing users to configure image grouping in the Recent Files view.

Behaviour

Grouping only occurs in the Recent Files view when this option is enabled
When an image upload is detected, a time window opens from its timestamp with a duration defined in the settings
- Subsequent images uploaded within that window are collected into the same group
- If a non-image file is uploaded within the active time window, grouping is suppressed and no group is formed for that batch
- Once the window closes or is suppressed, the next uploaded image starts a fresh time window
- This process repeats for the entire list, producing as many groups as the data allows
Groups can be expanded or collapsed to show/hide individual images
Selecting a group selects all images within it, with indeterminate state when partially selected

Visuals

demo.webm

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)
Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
Milestone added for target branch/version (ex: 32.x for stable32)

AI (if applicable)

The content of this PR was partly or fully generated using AI

cristianscheid · 2026-03-18T18:40:07Z

/compile

nfebe

yolod

susnux · 2026-03-23T16:26:24Z

Has this been approved by @nextcloud/designers ?

apps/files/src/components/FileEntryImageGroup.vue

susnux

blocking for two reasons:

This is completely changing the UI/UX and should go through feature planning / @nextcloud/designers review
Have you properly checked virtual scrolling? What happens if you extend them and then scroll down over the scroll order? Because now one item is no longer a fixed height and that can likely break all of the virtual scrolling

apps/files/src/components/FilesListVirtual.vue

cristianscheid · 2026-03-23T16:47:07Z

Has this been approved by @nextcloud/designers ?

Pinging as requested, thanks for the reminder! @marcoambrosini @kra-mo could you please take a look at this PR to see if it's ok from a design POV?

A demo video is available in the PR description, and below is an updated recording after incorporating @susnux suggestions, focusing on the grouping UI in the Recent section:

demo.webm

Also a closer screenshot:

susnux

some comments otherwise

apps/files/src/components/FileEntryImageGroup.vue

susnux · 2026-03-23T18:08:22Z

apps/files/src/components/FileEntryImageGroup.vue

IMHO it makes more sense to make this more generic, meaning just make this a group based on mime type. Of cause for now you can use image formats but then we can adjust this if needed anytime and dont create special cases :)

The reason we have comparatively few issues in the files app nowadays is the results of the quite flexible way we changed if when migrated from jQuery.

cristianscheid · 2026-03-23T18:52:21Z

Have you properly checked virtual scrolling? What happens if you extend them and then scroll down over the scroll order? Because now one item is no longer a fixed height and that can likely break all of the virtual scrolling

Hi @susnux, not sure if this is what you meant, but I've tested manually with 2 image groups and 33 images total. Expanding and collapsing groups correctly pushes items down and up without any overlap, gaps, or rendering issues while scrolling.

demo.webm

kra-mo · 2026-03-23T22:13:38Z

The feature itself looks like a nice enhancement from the design side, however it should definitely not be opt-in and we should definitely not add settings for this in general. See our design guidelines.

Can't it just be enabled by default with common image types and that's that, without extra options?

kra-mo · 2026-03-23T22:17:35Z

Common image types I guess being .png, .jpg, .jpeg, .webp, .avif, .jxl, .gif, .tiff, .heic, did I miss something?

kra-mo · 2026-03-23T22:19:32Z

Ah, it's actually using MIME types. In that case, can't it just be image/* in general?

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

…er to FileEntry component Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

…mports on FilesListVirtual Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

…yntax Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

susnux · 2026-03-24T02:57:59Z

apps/files/src/components/FileEntryWrapper.vue

+		v-bind="$attrs" />
+</template>
+
+<script lang="ts">


please directly use script setup syntax for all new components, helping to not create new backlog and simplify boilerplate

susnux · 2026-03-24T02:58:55Z

apps/files/src/components/FileEntryImageGroup.vue

+                @update:modelValue="onSelectionChange" />
+        </td>
+
+        <td class="files-list__row-name" @click="emit('toggle', source.source)">


This must be changed this is not accessible.
You cannot put the event listener on the td element as this is not interactive for keyboard users.

You will have to put in either a proper a or button element with the proper semantics to make this accessible.

susnux · 2026-03-24T03:03:03Z

apps/files/src/composables/useImageGrouping.ts

+import type { INode } from '@nextcloud/files'
+
+// eslint-disable-next-line perfectionist/sort-named-imports
+import { type Ref, computed } from 'vue'


Please fix instead of ignore this.

Suggested change

import type { INode } from '@nextcloud/files'

// eslint-disable-next-line perfectionist/sort-named-imports

import { type Ref, computed } from 'vue'

import type { INode } from '@nextcloud/files'

import type { Ref } from 'vue'

import { computed } from 'vue'

lib/private/Files/Cache/QuerySearchHelper.php

susnux · 2026-03-24T03:08:51Z

apps/files/lib/Service/UserConfig.php

+				'image/png',
+				'image/jpeg',
+				'image/gif',
+				'image/webp',
+				'image/avif',
+				'image/heic',
+				'image/heif',


What about tif or other image formats?
We could just always (if grouping is enabled) group by mime group, e.g. image/* and / or video/*

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

cristianscheid · 2026-03-24T23:58:32Z

Quick update on the state of this PR:

after internal discussion with @artonge, it was agreed that this PR should focus only on the backend part for now.

I'll update the PR asap.

skjnldsv

Is there some demand for it?
I'm asking because I'm really not sure this is something we want. The files app aims to be as simple as we can, the virtual scroller is already sooo complicated to maintain, this is really not somethign we wanna mess with.

How does it looks like from an accessible POV too ? From a semantic POV ? With a screen reader ?

Personally, while this looks nice, I don't think this have a place on our FIles app as of now. I've never seen this mechanics used in another file browser :)

@nfebe

@nfebe please no yolo on such drastic changes

cristianscheid · 2026-03-26T17:18:51Z

Is there some demand for it? I'm asking because I'm really not sure this is something we want. The files app aims to be as simple as we can, the virtual scroller is already sooo complicated to maintain, this is really not somethign we wanna mess with.

How does it looks like from an accessible POV too ? From a semantic POV ? With a screen reader ?

Personally, while this looks nice, I don't think this have a place on our FIles app as of now. I've never seen this mechanics used in another file browser :)

Thanks for the input @skjnldsv, really appreciated! After internal discussion, this PR will likely not move forward as is. We'll focus on the backend part (exposing configs/flags via OCC) and the frontend changes will probably be dropped.

cristianscheid force-pushed the feat/1701/recent-files-img-grouping branch 3 times, most recently from a9c6f99 to 8a2e1da Compare March 18, 2026 17:11

cristianscheid mentioned this pull request Mar 18, 2026

feat(recent-search): add nc:upload_time as a select prop nextcloud-libraries/nextcloud-files#1543

Open

7 tasks

cristianscheid self-assigned this Mar 18, 2026

cristianscheid added enhancement 2. developing Work in progress labels Mar 18, 2026

cristianscheid force-pushed the feat/1701/recent-files-img-grouping branch from a9b23e1 to f08a1c9 Compare March 19, 2026 10:22

nextcloud-command force-pushed the feat/1701/recent-files-img-grouping branch from f08a1c9 to 11b45bf Compare March 19, 2026 11:25

cristianscheid marked this pull request as ready for review March 19, 2026 11:40

cristianscheid requested review from a team and skjnldsv as code owners March 19, 2026 11:40

cristianscheid requested review from ArtificialOwl, CarlSchwan, leftybournes, nfebe and szaimen and removed request for a team March 19, 2026 11:40

cristianscheid added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 19, 2026

cristianscheid force-pushed the feat/1701/recent-files-img-grouping branch 2 times, most recently from 1da5753 to e872416 Compare March 20, 2026 10:27

nfebe previously approved these changes Mar 23, 2026

View reviewed changes

susnux reviewed Mar 23, 2026

View reviewed changes

apps/files/src/components/FileEntryImageGroup.vue Outdated Show resolved Hide resolved

susnux requested changes Mar 23, 2026

View reviewed changes

susnux reviewed Mar 23, 2026

View reviewed changes

apps/files/src/components/FilesListVirtual.vue Outdated Show resolved Hide resolved

cristianscheid force-pushed the feat/1701/recent-files-img-grouping branch from e872416 to 31ab098 Compare March 23, 2026 17:35

susnux reviewed Mar 23, 2026

View reviewed changes

cristianscheid and others added 5 commits March 24, 2026 09:17

feat(recent-files): implement image grouping based on configuration

5bb846e

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

chore(assets): Recompile assets

f1ed770

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>

fix(files): explicitly pass availability props through FileEntryWrapp…

95d7635

…er to FileEntry component Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

feat(recent-files): use NcIconSvgWrapper instead of Chevron and fix i…

5888b1a

…mports on FilesListVirtual Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

refactor(recent-files): convert FileEntryImageGroup to script setup s…

e4a01e0

…yntax Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

susnux reviewed Mar 24, 2026

View reviewed changes

fix(recent-files): join extended cache only when needed on search

2d9f283

Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>

cristianscheid force-pushed the feat/1701/recent-files-img-grouping branch from bc434eb to 2d9f283 Compare March 24, 2026 23:57

skjnldsv requested changes Mar 26, 2026

View reviewed changes

Uh oh!

Conversation

cristianscheid commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Behaviour

Visuals

Checklist

AI (if applicable)

Uh oh!

cristianscheid commented Mar 18, 2026

Uh oh!

nfebe left a comment

Choose a reason for hiding this comment

Uh oh!

susnux commented Mar 23, 2026

Uh oh!

Uh oh!

susnux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cristianscheid commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

susnux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

susnux Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

cristianscheid commented Mar 23, 2026

Uh oh!

kra-mo commented Mar 23, 2026

Uh oh!

kra-mo commented Mar 23, 2026

Uh oh!

kra-mo commented Mar 23, 2026

Uh oh!

susnux Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

susnux Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

susnux Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

susnux Mar 24, 2026

Choose a reason for hiding this comment

Uh oh!

cristianscheid commented Mar 24, 2026

Uh oh!

skjnldsv left a comment

Choose a reason for hiding this comment

Uh oh!

cristianscheid commented Mar 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cristianscheid commented Mar 13, 2026 •

edited

Loading

cristianscheid commented Mar 23, 2026 •

edited

Loading