fix: manually set modified time to SFTP files after editing#58970
fix: manually set modified time to SFTP files after editing#58970
Conversation
artonge
left a comment
There was a problem hiding this comment.
Looks good, but no idea if that works in practice. Have you tested it?
|
Yes, I tested it locally with Collabora. Collabora no longer shows that the file has been modified, even though it hasn't. |
21cc6d8 to
f71c382
Compare
|
Thank you for the feedback. I've updated the code. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
…tead Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Hendrik Leidinger <hendrik.leidinger@nextcloud.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
|
(rebased and updated psalm baseline entry) |
Summary
This PR fixes SFTP file writes. When uploading a file to the SFTP server, the files original modified date is not preserved. The SFTP server typically sets the modified date to the time of upload. This leads to issues, for example, with Nextcloud Office, which expects the mtime to match the mtime of the file. Nextcloud office then repeatedly throws errors indicating that the file has been modified externally. In this PR the SFTP implementation explicitely sets the modified date of the file.
Caution
I am not sure about the knownMTimes. I set them everywhere the data is written to the SFTP server, but I'm not sure if that's correct, since I'm not entirely sure what the purpose of this memory cache is.
Checklist
3. to review, feature component)stable32)AI (if applicable)