Skip to content

fix(group): pass previous display name in GroupChangedEvent#58990

Merged
artonge merged 1 commit intonextcloud:masterfrom
mosi-kha:fix/group-displayname-event-oldvalue
Mar 26, 2026
Merged

fix(group): pass previous display name in GroupChangedEvent#58990
artonge merged 1 commit intonextcloud:masterfrom
mosi-kha:fix/group-displayname-event-oldvalue

Conversation

@mosi-kha
Copy link
Copy Markdown
Contributor

@mosi-kha mosi-kha commented Mar 17, 2026

Summary

GroupChangedEvent old value was empty string,

TODO

  • fix: now passes previous display name,

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: mostafa <mostafakhaki00@gmail.com>
@mosi-kha mosi-kha requested a review from a team as a code owner March 17, 2026 09:25
@mosi-kha mosi-kha requested review from CarlSchwan, artonge, leftybournes and salmart-dev and removed request for a team March 17, 2026 09:25
@mosi-kha
Copy link
Copy Markdown
Contributor Author

Hi
if possible, backport it into stable32.
thanks

Copy link
Copy Markdown
Collaborator

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

In which context do you need that information?

@mosi-kha
Copy link
Copy Markdown
Contributor Author

Makes sense.

In which context do you need that information?

Thanks for the approval.
I’m handling group change events and needed access to both the old and new values for additional processing. Since the old value was not included in the event, I introduced a patch to provide it.

@artonge artonge enabled auto-merge March 26, 2026 11:40
@artonge artonge merged commit 309d12a into nextcloud:master Mar 26, 2026
361 of 372 checks passed
@welcome
Copy link
Copy Markdown

welcome bot commented Mar 26, 2026

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@mosi-kha
Copy link
Copy Markdown
Contributor Author

@artonge
Thanks for merge
Can you backport it with stable32 too?

@mosi-kha mosi-kha deleted the fix/group-displayname-event-oldvalue branch March 28, 2026 11:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants