feat(files_external): convert to delegated settings#59001
Draft
tanyaka wants to merge 1 commit intonextcloud:masterfrom
Draft
feat(files_external): convert to delegated settings#59001tanyaka wants to merge 1 commit intonextcloud:masterfrom
tanyaka wants to merge 1 commit intonextcloud:masterfrom
Conversation
tanyaka
force-pushed
the
tkl/dev/files_external-delegation-rebased-on-NC
branch
from
ca7bcb8 to
5471772
Compare
tanyaka
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
tanyaka
force-pushed
the
tkl/dev/files_external-delegation-rebased-on-NC
branch
2 times, most recently
from
88defbc to
d8787fd
Compare
tanyaka
changed the title
tanyaka
force-pushed
the
tkl/dev/files_external-delegation-rebased-on-NC
branch
2 times, most recently
from
d17b4eb to
bd70a66
Compare
printminion-co
force-pushed
the
tkl/dev/files_external-delegation-rebased-on-NC
branch
from
bd70a66 to
3488153
Compare
artonge
reviewed
Mar 26, 2026
Collaborator
artonge
left a comment
artonge
left a comment
There was a problem hiding this comment.
Is this enough? Have you tested it?
The documentation says that we might also need to add the AuthorizedAdminSetting attribute to the endpoints. Is it the case for this PR?
https://docs.nextcloud.com/server/latest/developer_manual/basics/setting.html#settings
Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
tanyaka
force-pushed
the
tkl/dev/files_external-delegation-rebased-on-NC
branch
from
3488153 to
7d8b598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds admin‑delegation support for the External storage app (files_external) and hardens credential handling.
Changes Made
Checklist
3. to review, feature component)stable32)AI (if applicable)