Skip to content

fix: use unjailed source path when moving jailed files#59252

Merged
salmart-dev merged 1 commit intomasterfrom
fix/move-with-unjailed-source-path
Mar 30, 2026
Merged

fix: use unjailed source path when moving jailed files#59252
salmart-dev merged 1 commit intomasterfrom
fix/move-with-unjailed-source-path

Conversation

@salmart-dev
Copy link
Copy Markdown
Contributor

@salmart-dev salmart-dev commented Mar 27, 2026

Summary

When moving directories across storages wrapped in multiple Jails, paths of contained files are not updated correctly and lead to shares being broken.

How to reproduce the issue

  1. As admin A
  2. Create a group folder and share it with a group where user B is part of
  3. Create folders Share 1 and Share 2 inside the group folder and share them with User B
  4. Add a directory with files inside one of the two Share folders using user A
  5. Using B navigate into the Share folder containing the directory (not the group folder)
  6. Move the directory to the other Share folder without going through the groupfolder

Expected result: the share folder is accessible and navigating into the moved folder using the share works
Actual result: the share folder or the moved folder become inaccessible causing the exception visible in the attached ticket (getOwner receiving null).

The reason for this is that the path of the storage and the path of the files inside the directory become off-sync.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@salmart-dev salmart-dev self-assigned this Mar 27, 2026
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com>
@salmart-dev salmart-dev force-pushed the fix/move-with-unjailed-source-path branch from 7398845 to bf24b24 Compare March 27, 2026 13:30
@salmart-dev salmart-dev added this to the Nextcloud 34 milestone Mar 30, 2026
@salmart-dev salmart-dev marked this pull request as ready for review March 30, 2026 10:51
@salmart-dev salmart-dev requested a review from a team as a code owner March 30, 2026 10:51
@salmart-dev salmart-dev requested review from Altahrim, ArtificialOwl, CarlSchwan and leftybournes and removed request for a team March 30, 2026 10:51
@salmart-dev
Copy link
Copy Markdown
Contributor Author

/backport to stable33

@salmart-dev
Copy link
Copy Markdown
Contributor Author

/backport to stable32

@salmart-dev
Copy link
Copy Markdown
Contributor Author

/backport to stable31

@salmart-dev salmart-dev merged commit 9756097 into master Mar 30, 2026
212 of 219 checks passed
@salmart-dev salmart-dev deleted the fix/move-with-unjailed-source-path branch March 30, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Shared folder path resolves to null

3 participants