Skip to content

chore: Move StorageObjectStore into test support without changing coverage#59280

Open
joshtrichards wants to merge 18 commits intomasterfrom
jtr/test-StorageObjectStore-move-from-prod
Open

chore: Move StorageObjectStore into test support without changing coverage#59280
joshtrichards wants to merge 18 commits intomasterfrom
jtr/test-StorageObjectStore-move-from-prod

Conversation

@joshtrichards
Copy link
Copy Markdown
Member

@joshtrichards joshtrichards commented Mar 28, 2026

  • Resolves: #

Summary

This PR relocates StorageObjectStore from production object store code into test support code.

I've been confused by the presence of this class on numerous occasions. It took until today for me to look closer and realize it's 100% a test support class.

Why:

StorageObjectStore is used as a storage-backed test adapter, but currently lives next to production object store implementations. That makes it easy to confuse with a supported production backend.

Changes:

  • moved StorageObjectStore into /tests / etc and out of OC\ namespace
  • renamed to StorageBackedObjectStore for added clarity
  • updated affected tests and references
  • kept the same behavior and test usage patterns after relocation

Notes;

  • This change is organizational only.
  • The tests affected by the move still exercise the same code paths and functionality for all practical purposes:
    • object-store contract behavior is still covered
    • ObjectStoreStorage behavior is still covered
    • PrimaryObjectStoreConfig coverage is preserved, with the same kind of configured class-string usage as before

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Replaces class StorageObjectStore that currently exits in production code but is purely a test support class and renames it to make use-case somewhat clearer.

Signed-off-by: Josh <josh.t.richards@gmail.com>
Replaced with test-only class StorageBackedObjectStore

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…tStore

Signed-off-by: Josh <josh.t.richards@gmail.com>
…ObjectStore

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
…Store

Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added this to the Nextcloud 34 milestone Mar 28, 2026
@joshtrichards joshtrichards marked this pull request as ready for review March 28, 2026 02:39
@joshtrichards joshtrichards requested a review from a team as a code owner March 28, 2026 02:39
@joshtrichards joshtrichards requested review from ArtificialOwl, CarlSchwan, icewind1991, leftybournes and salmart-dev and removed request for a team March 28, 2026 02:39
@joshtrichards joshtrichards added the 3. to review Waiting for reviews label Mar 28, 2026
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: object storage technical debt 🧱 🤔🚀 tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant