Skip to content

fix(weather_status): add all missing met.no symbol codes to weatherOptions#59317

Merged
sorbaugh merged 2 commits intonextcloud:masterfrom
psimaker:fix/weather-status-missing-codes
Mar 31, 2026
Merged

fix(weather_status): add all missing met.no symbol codes to weatherOptions#59317
sorbaugh merged 2 commits intonextcloud:masterfrom
psimaker:fix/weather-status-missing-codes

Conversation

@psimaker
Copy link
Copy Markdown
Contributor

Fixes #59292

The weatherOptions object in apps/weather_status/src/App.vue only mapped 25 of 83 valid symbol_code values from the met.no Locationforecast API. Any unmapped code caused the widget to show "Unknown weather code".

This PR adds the remaining 58 codes following the existing pattern. All icons were already in place as confirmed by @joshtrichards.

@susnux susnux added this to the Nextcloud 34 milestone Mar 31, 2026
@susnux
Copy link
Copy Markdown
Contributor

susnux commented Mar 31, 2026

@psimaker thank you for your pull request!
Please do not merge the main branch into your branch but just rebase the branch :)

Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@psimaker psimaker force-pushed the fix/weather-status-missing-codes branch from 44727c1 to 701baf9 Compare March 31, 2026 09:53
@psimaker
Copy link
Copy Markdown
Contributor Author

@susnux - Done — rebased onto current master. Sorry for the merge commit, lesson learned!

@susnux
Copy link
Copy Markdown
Contributor

susnux commented Mar 31, 2026

@psimaker this looks good!
Can you please rebase to latest master state and then compile the frontend and commit the assets as a new commit?

npm ci
npm run build

…tions

Signed-off-by: psimaker <psimaker@users.noreply.github.com>
Signed-off-by: psimaker <psimaker@users.noreply.github.com>
@psimaker psimaker force-pushed the fix/weather-status-missing-codes branch from 701baf9 to 19b0c91 Compare March 31, 2026 10:24
@psimaker
Copy link
Copy Markdown
Contributor Author

@psimaker this looks good! Can you please rebase to latest master state and then compile the frontend and commit the assets as a new commit?

npm ci
npm run build

done. rebased onto current master and compiled frontend assets.

@susnux
Copy link
Copy Markdown
Contributor

susnux commented Mar 31, 2026

/backport af8cb33 to stable32

@susnux
Copy link
Copy Markdown
Contributor

susnux commented Mar 31, 2026

/backport af8cb33 to stable33

@sorbaugh sorbaugh merged commit 22c75f5 into nextcloud:master Mar 31, 2026
113 of 120 checks passed
@welcome
Copy link
Copy Markdown

welcome bot commented Mar 31, 2026

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Weather status widget shows "Unknown weather code" for sleet and other unmapped met.no symbol codes

5 participants