perf: cache authorized-group delegation lookups#59328
Open
perf: cache authorized-group delegation lookups#59328
Conversation
solracsf
force-pushed
the
perfCacheAuthorizedGroupLookups
branch
2 times, most recently
from
ee331fb to
953b44b
Compare
solracsf
requested review from
Altahrim,
CarlSchwan,
artonge and
leftybournes
and removed request for
a team
solracsf
added
3. to review
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
perfCacheAuthorizedGroupLookups
branch
from
953b44b to
22630a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repeated group-backend and DB queries on every
#[AuthorizedAdminSetting]request, every share formatting call, and every group-membership hook are replaced by scoped caches (per-request arrays, a two-tier local+distributed cache, and a per-instance memoization property). All four write paths on authorized_groups invalidate the cache throughAuthorizedGroupService, which now batches N mutations into a singleclearCache()call.A
UNIQUEconstraint ongroup_idis added via migration, closing a concurrent-write race that the previous applicative pre-check could not cover. Duplicate rows on existing instances are cleaned up inpreSchemaChange()before the index is created.Checklist
3. to review, feature component)stable32)AI (if applicable)