fix: update email button text to 'Open shared item'#59330
Open
fix: update email button text to 'Open shared item'#59330
Conversation
solracsf
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
leftybournes
and removed request for
a team
Member
Author
|
Cc @nextcloud/designers |
solracsf
requested review from
kra-mo,
marcoambrosini,
nimishavijay and
szaimen
and removed request for
Altahrim,
ArtificialOwl,
icewind1991 and
leftybournes
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
btnOpenShare-2
branch
from
c860384 to
545a9c1
Compare
szaimen
approved these changes
Mar 31, 2026
Contributor
szaimen
left a comment
szaimen
left a comment
There was a problem hiding this comment.
Makes sense from my POV and good idea! :)
jancborchardt
added
the
papercut
jancborchardt
approved these changes
Mar 31, 2026
Member
jancborchardt
left a comment
jancborchardt
left a comment
There was a problem hiding this comment.
Nice fix @solracsf! :) Looks better, and especially considering the button breakage on mobile this is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
No need to list the same content (file/folder name) twice in the mail (less is better).
Also, when share name is long, it breaks the button on small devices.
Before
After
Checklist
3. to review, feature component)stable32)AI (if applicable)