fix: duplicate dashboard widget#59335
Open
mykh-hailo wants to merge 2 commits intonextcloud:masterfrom
Open
Conversation
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
mykh-hailo
requested review from
Altahrim,
CarlSchwan,
leftybournes and
provokateurin
and removed request for
a team
susnux
reviewed
Mar 31, 2026
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
Thank you for your pull request!
I have just one comment:
Signed-off-by: mykh-hailo <kristianderonta0205@gmail.com>
susnux
approved these changes
Mar 31, 2026
Contributor
|
/backport to stable33 |
Contributor
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a dashboard layout edge case where duplicate widget IDs can be sent to the layout update endpoint.
Even though the UI only allows selecting a widget once, crafted requests could still submit duplicates (e.g.
layout[]=files&layout[]=files). This caused duplicated entries to be persisted.Checklist
3. to review, feature component)stable32)AI (if applicable)