Skip to content

WIP: fix(encryption): store key by fileId for CollectiveMountPoint#59343

Draft
mejo- wants to merge 1 commit intomasterfrom
fix/encryption_key_by_file_id
Draft

WIP: fix(encryption): store key by fileId for CollectiveMountPoint#59343
mejo- wants to merge 1 commit intomasterfrom
fix/encryption_key_by_file_id

Conversation

@mejo-
Copy link
Copy Markdown
Member

@mejo- mejo- commented Mar 31, 2026

Summary

In Collectives, we can have different paths to a file by user (when a user changes their user_folder user setting). This leads to inaccessible files with server-side encryption as the encryption keys are stored by file path. In order to fix this, we should switch to fileId based key storage instead of file path based key storage.

TODO

  • Decide whether we want to always store encryption keys by fileId, or just for ISystemMountPoint or just for CollectiveMountPoint
  • Decide whether we change all the interfaces and functions to pass $fileId through encryption storage wrapper or whether it's acceptable to use $this->rootView->getFileInfo() in Util.php.
  • [ ]

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant