fix(files_reminders): switch from DB-side NOW() to PHP-side generation#59358
Open
joshtrichards wants to merge 2 commits intomasterfrom
Open
fix(files_reminders): switch from DB-side NOW() to PHP-side generation#59358joshtrichards wants to merge 2 commits intomasterfrom
NOW() to PHP-side generation#59358joshtrichards wants to merge 2 commits intomasterfrom
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
added
3. to review
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
salmart-dev
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DB-side
NOW()is dependent on database server/session config. We want to know it's always UTC. We already generate timestamps PHP-side typically. This switches the now timestamp generate to be PHP-side for consistency, robustness in all environments, and also to make unit testing easier.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)