fix(user): invalidate folder ETag when quota changes

lib/composer/composer/autoload_classmap.php

@@ -2257,6 +2257,7 @@
     'OC\\User\\LazyUser' => $baseDir . '/lib/private/User/LazyUser.php',
     'OC\\User\\Listeners\\BeforeUserDeletedListener' => $baseDir . '/lib/private/User/Listeners/BeforeUserDeletedListener.php',
     'OC\\User\\Listeners\\UserChangedListener' => $baseDir . '/lib/private/User/Listeners/UserChangedListener.php',
+    'OC\\User\\Listeners\\UserQuotaChangedListener' => $baseDir . '/lib/private/User/Listeners/UserQuotaChangedListener.php',
     'OC\\User\\LoginException' => $baseDir . '/lib/private/User/LoginException.php',
     'OC\\User\\Manager' => $baseDir . '/lib/private/User/Manager.php',
     'OC\\User\\NoUserException' => $baseDir . '/lib/private/User/NoUserException.php',

lib/composer/composer/autoload_static.php

@@ -2298,6 +2298,7 @@ class ComposerStaticInit749170dad3f5e7f9ca158f5a9f04f6a2
         'OC\\User\\LazyUser' => __DIR__ . '/../../..' . '/lib/private/User/LazyUser.php',
         'OC\\User\\Listeners\\BeforeUserDeletedListener' => __DIR__ . '/../../..' . '/lib/private/User/Listeners/BeforeUserDeletedListener.php',
         'OC\\User\\Listeners\\UserChangedListener' => __DIR__ . '/../../..' . '/lib/private/User/Listeners/UserChangedListener.php',
+        'OC\\User\\Listeners\\UserQuotaChangedListener' => __DIR__ . '/../../..' . '/lib/private/User/Listeners/UserQuotaChangedListener.php',
         'OC\\User\\LoginException' => __DIR__ . '/../../..' . '/lib/private/User/LoginException.php',
         'OC\\User\\Manager' => __DIR__ . '/../../..' . '/lib/private/User/Manager.php',
         'OC\\User\\NoUserException' => __DIR__ . '/../../..' . '/lib/private/User/NoUserException.php',

lib/private/User/Listeners/UserQuotaChangedListener.php

@@ -0,0 +1,39 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+namespace OC\User\Listeners;
+
+use OCP\EventDispatcher\Event;
+use OCP\EventDispatcher\IEventListener;
+use OCP\Files\IRootFolder;
+use OCP\User\Events\UserChangedEvent;
+
+/**
+ * @template-implements IEventListener<UserChangedEvent>
+ */
+class UserQuotaChangedListener implements IEventListener {
+	public function __construct(
+		private IRootFolder $rootFolder,
+	) {
+	}
+
+	public function handle(Event $event): void {
+		if ($event instanceof UserChangedEvent && $event->getFeature() === 'quota') {
+			try {
+				$userFolder = $this->rootFolder->getUserFolder($event->getUser()->getUID());
+				$userFolder->getStorage()->getCache()->update(
+					$userFolder->getId(),
+					['etag' => uniqid()]
+				);
+			} catch (\Throwable) {
+				// Non-fatal: best-effort ETag invalidation.
+				// Stale quota corrects itself on the client's next full sync.
+			}
+		}
+	}
+}

tests/lib/User/Listeners/UserQuotaChangedListenerTest.php

@@ -0,0 +1,81 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * SPDX-FileCopyrightText: 2024 Nextcloud GmbH and Nextcloud contributors
+ * SPDX-License-Identifier: AGPL-3.0-or-later
+ */
+namespace Test\User\Listeners;
+
+use OC\User\Listeners\UserQuotaChangedListener;
+use OCP\EventDispatcher\Event;
+use OCP\Files\Cache\ICache;
+use OCP\Files\Folder;
+use OCP\Files\IRootFolder;
+use OCP\Files\Storage\IStorage;
+use OCP\IUser;
+use OCP\User\Events\UserChangedEvent;
+use PHPUnit\Framework\MockObject\MockObject;
+use Test\TestCase;
+
+class UserQuotaChangedListenerTest extends TestCase {
+	private IRootFolder&MockObject $rootFolder;
+	private UserQuotaChangedListener $listener;
+
+	protected function setUp(): void {
+		parent::setUp();
+		$this->rootFolder = $this->createMock(IRootFolder::class);
+		$this->listener = new UserQuotaChangedListener($this->rootFolder);
+	}
+
+	public function testIgnoresNonUserChangedEvent(): void {
+		$this->rootFolder->expects($this->never())->method('getUserFolder');
+		$this->listener->handle($this->createMock(Event::class));
+	}
+
+	public function testIgnoresNonQuotaFeature(): void {
+		$user = $this->createMock(IUser::class);
+		$event = new UserChangedEvent($user, 'displayName', 'Alice', 'Bob');
+
+		$this->rootFolder->expects($this->never())->method('getUserFolder');
+		$this->listener->handle($event);
+	}
+
+	public function testInvalidatesEtagOnQuotaChange(): void {
+		$user = $this->createMock(IUser::class);
+		$user->method('getUID')->willReturn('alice');
+
+		$cache = $this->createMock(ICache::class);
+		$cache->expects($this->once())
+			->method('update')
+			->with($this->isInt(), $this->callback(
+				fn (array $data) => isset($data['etag']) && $data['etag'] !== ''
+			));
+
+		$storage = $this->createMock(IStorage::class);
+		$storage->method('getCache')->willReturn($cache);
+
+		$userFolder = $this->createMock(Folder::class);
+		$userFolder->method('getStorage')->willReturn($storage);
+		$userFolder->method('getId')->willReturn(42);
+
+		$this->rootFolder->method('getUserFolder')->with('alice')->willReturn($userFolder);
+
+		$event = new UserChangedEvent($user, 'quota', '5 GB', '1 GB');
+		$this->listener->handle($event);
+	}
+
+	public function testSwallowsExceptionGracefully(): void {
+		$user = $this->createMock(IUser::class);
+		$user->method('getUID')->willReturn('alice');
+
+		$this->rootFolder->method('getUserFolder')
+			->willThrowException(new \Exception('Storage unavailable'));
+
+		// Should not throw
+		$event = new UserChangedEvent($user, 'quota', '5 GB', '1 GB');
+		$this->listener->handle($event);
+		$this->addToAssertionCount(1);
+	}
+}