[stable32] fix(settings): do not show admin section container if empty#59428
Open
[stable32] fix(settings): do not show admin section container if empty#59428
Conversation
susnux
requested review from
Altahrim,
artonge,
leftybournes and
provokateurin
and removed request for
a team
Contributor
Author
|
/backport to stable33 |
github-actions
bot
changed the title
- fixes #59337 Already fixed for Nextcloud 34+ but here we need to fix the legacy navigation as well. The problem is that empty `<ul>` elements are not allowed, lists always require at least one list item for accessibility. Ref: https://www.w3.org/TR/wai-aria-1.2/#mustContain Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/settings-sections-32
branch
from
cd44cfd to
d783cab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Already fixed for Nextcloud 34+ but here we need to fix the legacy navigation as well.
The problem is that empty
<ul>elements are not allowed, lists always require at least one list item for accessibility. Ref: https://www.w3.org/TR/wai-aria-1.2/#mustContainChecklist
3. to review, feature component)stable32)AI (if applicable)