Skip to content

feat: add config header and tests.#59462

Open
Keeper-of-the-Keys wants to merge 1 commit intonextcloud:masterfrom
Keeper-of-the-Keys:config-header-attempt-2
Open

feat: add config header and tests.#59462
Keeper-of-the-Keys wants to merge 1 commit intonextcloud:masterfrom
Keeper-of-the-Keys:config-header-attempt-2

Conversation

@Keeper-of-the-Keys
Copy link
Copy Markdown
Contributor

@Keeper-of-the-Keys Keeper-of-the-Keys commented Apr 5, 2026

Summary

config.php is re-rendered by nextcloud regularly removing comments and rendering constants into their values, nextcloud supports using multiple config files and renders their content into the main config.php without modifying the external files.
This PR adds a header to config.php warning the admin/user of this and suggesting the use of the multiple config files mechanism.

TODO

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: E.S. Rosenberg a.k.a. Keeper of the Keys <es-github@rosenberg.org.il>
@Keeper-of-the-Keys Keeper-of-the-Keys requested a review from a team as a code owner April 5, 2026 21:53
@Keeper-of-the-Keys Keeper-of-the-Keys requested review from ArtificialOwl, artonge, leftybournes and salmart-dev and removed request for a team April 5, 2026 21:53
@Keeper-of-the-Keys
Copy link
Copy Markdown
Contributor Author

Tagging: @provokateurin @miaulalala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Upgrade process re-renders config.php in a less readable/useable fashion

2 participants