feat: add config header and tests.#59462
Open
Keeper-of-the-Keys wants to merge 1 commit intonextcloud:masterfrom
Open
feat: add config header and tests.#59462Keeper-of-the-Keys wants to merge 1 commit intonextcloud:masterfrom
Keeper-of-the-Keys wants to merge 1 commit intonextcloud:masterfrom
Conversation
Signed-off-by: E.S. Rosenberg a.k.a. Keeper of the Keys <es-github@rosenberg.org.il>
Contributor
Author
|
Tagging: @provokateurin @miaulalala |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.phpis re-rendered by nextcloud regularly removing comments and rendering constants into their values, nextcloud supports using multiple config files and renders their content into the main config.php without modifying the external files.This PR adds a header to
config.phpwarning the admin/user of this and suggesting the use of the multiple config files mechanism.TODO
config.phpin the order that they were included will probably help admins troubleshoot if a config variable is doubled up by mistake.Checklist
Screenshots before/after for front-end changesBackports requested where applicable (ex: critical bugfixes)3. to review, feature component)stable32)AI (if applicable)
The content of this PR was partly or fully generated using AI