Skip to content

fix(testing): Fix fake provider reverting strings with emojis#59566

Merged
nickvergessen merged 1 commit intomasterfrom
bugfix/noid/fix-reverting-multibyte-strings
Apr 10, 2026
Merged

fix(testing): Fix fake provider reverting strings with emojis#59566
nickvergessen merged 1 commit intomasterfrom
bugfix/noid/fix-reverting-multibyte-strings

Conversation

@nickvergessen
Copy link
Copy Markdown
Member

Before After
image Bildschirmfoto vom 2026-04-10 15-51-25

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@nickvergessen nickvergessen added this to the Nextcloud 34 milestone Apr 10, 2026
@nickvergessen nickvergessen self-assigned this Apr 10, 2026
@nickvergessen nickvergessen requested a review from a team as a code owner April 10, 2026 13:54
@nickvergessen nickvergessen added 3. to review Waiting for reviews tests Related to tests labels Apr 10, 2026
@nickvergessen nickvergessen requested review from ArtificialOwl, come-nc, provokateurin and salmart-dev and removed request for a team April 10, 2026 13:54
Copy link
Copy Markdown
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-reverting-multibyte-strings branch from defa372 to 43c5fd3 Compare April 10, 2026 14:03
@nickvergessen
Copy link
Copy Markdown
Member Author

Fixed only cs+rector:

[40](https://github.com/nextcloud/server/actions/runs/24246433101/job/70793882121?pr=59566#step:5:141)
-		for ($i = mb_strlen($str); $i>=0; $i--) {
+		for ($i = mb_strlen($str); $i >= 0; $i--) {

@nickvergessen nickvergessen merged commit a2bb782 into master Apr 10, 2026
176 of 180 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/fix-reverting-multibyte-strings branch April 10, 2026 16:14
@nickvergessen
Copy link
Copy Markdown
Member Author

/backport to stable33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews tests Related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants