Skip to content

fix(files_sharing): do not double escape special characters#60457

Open
susnux wants to merge 2 commits into
masterfrom
fix/publicnickname
Open

fix(files_sharing): do not double escape special characters#60457
susnux wants to merge 2 commits into
masterfrom
fix/publicnickname

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented May 15, 2026

Summary

The strings are already escaped by Vue so no need to escape in the translation method, this will cause double escaping.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux susnux requested a review from a team as a code owner May 15, 2026 17:43
@susnux susnux requested review from nfebe, skjnldsv and sorbaugh and removed request for a team May 15, 2026 17:43
@susnux susnux requested review from szaimen and removed request for sorbaugh May 15, 2026 17:43
@susnux susnux added this to the Nextcloud 35 milestone May 15, 2026
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented May 15, 2026

/backport to stable34

@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented May 15, 2026

/backport to stable33

Copy link
Copy Markdown
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

- fixes #60163

The strings are already escaped by Vue so no need to escape in the
translation method, this will cause double escaping.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/publicnickname branch from ed5dc6d to 304f160 Compare May 16, 2026 08:02
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented May 16, 2026

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: File Request: "Enter your name" dialog displays HTML-encoded subject when special characters are used

5 participants