test(carddav): refactor testSearch to use clearer assertions and unique UIDs#60463
Open
joshtrichards wants to merge 2 commits into
Open
test(carddav): refactor testSearch to use clearer assertions and unique UIDs#60463joshtrichards wants to merge 2 commits into
joshtrichards wants to merge 2 commits into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
SebastianKrupinski
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors
testSearch()and its data provider inCardDavBackendTestto improve clarity and correctness:$expectedinto$expectedUris+$expectedNeedles: separates two concerns that were previously mixed into a single tuple arrayuid-0,uid-1,uid-2): the old shareduidvalue was invalid per the vCard spec and could mask bugsassertNotFalse(strpos(...)), giving actionable failure messages instead of a silent count mismatch$propertyRowsloopNo production code changes.
Checklist
3. to review, feature component)stable32)AI (if applicable)