feat: Renegotiation#2587
Open
SystemKeeper wants to merge 6 commits into
Open
Conversation
SystemKeeper
force-pushed
the
feat/noid/implement-renegotiation
branch
from
c74d43e to
82b2793
Compare
Collaborator
Author
|
Tested
All worked with this approach. We also found that 82b2793 works with Janus 0.x, but does not work with Janus 1.x. So there's something to check there (might be related to /janus-gateway/pull/3023) |
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
Assisted-by: ClaudeCode:claude-fable-5 Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
It only seems to work in some cases, sometimes it's only a black video is shown. Therefore we fallback to reconnect for now. Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
SystemKeeper
force-pushed
the
feat/noid/implement-renegotiation
branch
from
82b2793 to
d6abd89
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to test:
Without this PR: Reconnection
With this PR: Connection is upgrade to video
Without this PR: Not available
With this PR: Connection is downgraded to voice only
🤖 AI (if applicable)