fix(fonts): copy fonts into the correct place#1245
Conversation
Kinda fixes nextcloud#1215 Signed-off-by: Goldfels <Goldfels@users.noreply.github.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Thanks @Goldfels, this was exactly the right root cause. The Closing this in favor of #1263 to keep the fix in one place. Appreciate you catching this. |
In the plugin
vite-plugin-static-copystarting from version 4, there's a major breaking change: the folder structure is now always preserved. Because of this, when copying the fonts intodist, it is undernode_modules/...instead offonts, which breaks font loading from the server.This can be easily fixed with the new
renameoption.Technically, this also fixes #1215, since loading fonts from the server is allowed by the CSP.