Skip to content

fix(fonts): copy fonts into the correct place#1245

Closed
Goldfels wants to merge 1 commit into
nextcloud:mainfrom
Goldfels:main
Closed

fix(fonts): copy fonts into the correct place#1245
Goldfels wants to merge 1 commit into
nextcloud:mainfrom
Goldfels:main

Conversation

@Goldfels

Copy link
Copy Markdown

In the plugin vite-plugin-static-copy starting from version 4, there's a major breaking change: the folder structure is now always preserved. Because of this, when copying the fonts into dist, it is under node_modules/... instead of fonts, which breaks font loading from the server.

This can be easily fixed with the new rename option.

Technically, this also fixes #1215, since loading fonts from the server is allowed by the CSP.

Kinda fixes nextcloud#1215

Signed-off-by: Goldfels <Goldfels@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@hweihwang

Copy link
Copy Markdown
Contributor

Thanks @Goldfels, this was exactly the right root cause. The rename fix is included in #1263 now, together with the CSP fixes for Talk/backend connections and the Excalidraw fallback guard/test, so #1215 should be covered there too.

Closing this in favor of #1263 to keep the fix in one place. Appreciate you catching this.

@hweihwang hweihwang closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Fonts not loading due to Content Security Policy

2 participants