Prevent TaskPath leakage from typed record outputs#7090
Open
stekaz wants to merge 1 commit intonextflow-io:masterfrom
Open
Prevent TaskPath leakage from typed record outputs#7090stekaz wants to merge 1 commit intonextflow-io:masterfrom
stekaz wants to merge 1 commit intonextflow-io:masterfrom
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: Stephen Kazakoff <sh.kazakoff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7032
This change fixes the output-side problem where a process can emit a record containing TaskPath values. These TaskPath values are only meaningful inside the upstream task, so downstream processes can fail during hashing/staging or see invalid relative paths. The fix is to normalize the process output values before binding them to output channels.
#7083 makes nested record paths become TaskPaths when entering a task
This PR makes nested TaskPath values become durable paths when leaving a task