phylo: Add standardized multiple inputs#339
Merged
joverlee521 merged 6 commits intomasterfrom Oct 8, 2025
Merged
Conversation
subrepo: subdir: "shared/vendored" merged: "43e5a6f" upstream: origin: "https://github.com/nextstrain/shared" branch: "main" commit: "43e5a6f" git-subrepo: version: "0.4.6" origin: "https://github.com/ingydotnet/git-subrepo" commit: "110b9eb"
Note this does _not_ remove the support for `private_metadata` and `private_sequences` config params because they are used by the private INRB build to bypass the QC filtering for the contextual sequences. In the future we could explore using the inputs `name` to change filtering params, but I'll punt on that for now.
victorlin
approved these changes
Sep 30, 2025
joverlee521
added a commit
to nextstrain/shared
that referenced
this pull request
Sep 30, 2025
Add `min_version` in the shared `remote_files.smk` so that individual workflows that import it don't have to remember to add the version check. Based on feedback from @victorlin in mpox <nextstrain/mpox#339 (comment)>
2 tasks
c7ee9a6 to
b276e3f
Compare
Contributor
Author
|
Will merge this by EOD tomorrow if there are no other comments. |
for more information, see https://pre-commit.ci
b276e3f to
d7f2b97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Use latest guidance for handling inputs based on nextstrain/pathogen-repo-guide#91.
Note this does not remove the support for
private_metadataandprivate_sequencesconfig params because they are used by the private INRB build to bypass the QC filtering for the contextual sequences.Related issue(s)
Resolves #324
nextstrain/public#25
Checklist