Skip to content

phylo: Add standardized multiple inputs#339

Merged
joverlee521 merged 6 commits intomasterfrom
multiple-inputs
Oct 8, 2025
Merged

phylo: Add standardized multiple inputs#339
joverlee521 merged 6 commits intomasterfrom
multiple-inputs

Conversation

@joverlee521
Copy link
Copy Markdown
Contributor

@joverlee521 joverlee521 commented Sep 27, 2025

Description of proposed changes

Use latest guidance for handling inputs based on nextstrain/pathogen-repo-guide#91.

Note this does not remove the support for private_metadata and private_sequences config params because they are used by the private INRB build to bypass the QC filtering for the contextual sequences.

Related issue(s)

Resolves #324
nextstrain/public#25

Checklist

  • Checks pass
  • Update changelog
  • Update TBD date in changelog

subrepo:
  subdir:   "shared/vendored"
  merged:   "43e5a6f"
upstream:
  origin:   "https://github.com/nextstrain/shared"
  branch:   "main"
  commit:   "43e5a6f"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"
Note this does _not_ remove the support for `private_metadata` and 
`private_sequences` config params because they are used by the private INRB
build to bypass the QC filtering for the contextual sequences.

In the future we could explore using the inputs `name` to change filtering 
params, but I'll punt on that for now.
Comment thread CHANGELOG.md Outdated
Comment thread phylogenetic/Snakefile
joverlee521 added a commit to nextstrain/shared that referenced this pull request Sep 30, 2025
Add `min_version` in the shared `remote_files.smk` so that individual workflows 
that import it don't have to remember to add the version check. 

Based on feedback from @victorlin in mpox
<nextstrain/mpox#339 (comment)>
@joverlee521
Copy link
Copy Markdown
Contributor Author

Will merge this by EOD tomorrow if there are no other comments.

@joverlee521 joverlee521 merged commit 906b020 into master Oct 8, 2025
3 of 5 checks passed
@joverlee521 joverlee521 deleted the multiple-inputs branch October 8, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

phylogenetic: support standardized multiple input

2 participants