fix(nextstrain/rubella/E1): correct excessBandwidth typo#423
Merged
ivan-aksamentov merged 2 commits intomasterfrom Mar 5, 2026
Merged
fix(nextstrain/rubella/E1): correct excessBandwidth typo#423ivan-aksamentov merged 2 commits intomasterfrom
ivan-aksamentov merged 2 commits intomasterfrom
Conversation
Fix typo in alignmentParams.excessBandwith (missing 'd') to excessBandwidth. The misspelled key was silently ignored, causing the default bandwidth value (9) to be used instead of the intended value (18) during sequence alignment. Applied via: migrations/migrate_015_fix_excess_bandwidth_typo.py
Member
Author
1 task
Member
Author
|
Upstream fix: nextstrain/rubella#52 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix typo in
alignmentParams.excessBandwith(missing 'd') toexcessBandwidth.The misspelled key was silently ignored, causing the default bandwidth value (9) to be used instead of the intended value (18) during sequence alignment. This may have affected alignment quality for divergent E1 sequences.
Changes
Single character fix in rubella/E1/pathogen.json:
excessBandwith->excessBandwidthUpstream
Maintainer: Nextstrain (John SJ Anderson)
Upstream workflow: https://github.com/nextstrain/rubella
Action required: Please fix the typo in the rubella workflow to prevent it from recurring.
Reviewers
cc jsjohnst - dataset maintainer (John SJ Anderson)