Open
Conversation
feat: remove command k shortcut
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces UI improvements and new interactive features to the application, focusing on the header and card components. The most significant changes include a visual refresh of the header, removal of the global keyboard shortcut for the command palette, and the addition of a "like" (heart) button to both album and track cards. Additionally, a new dependency is added to
package.json.UI and UX Improvements:
Headerinsrc/common/Header/index.tsx) receives a visual refresh: it now always has a black background, fixed z-index, and consistently uses white text for all elements, regardless of page or scroll state. Conditional styling for NotFound and active states is removed, simplifying the appearance. [1] [2] [3] [4] [5]App.tsxis adjusted to add top padding, ensuring it sits below the fixed header.Feature Removal:
useEffectlistener fromApp.tsx. The palette can still be opened via the header button. The shortcut hint (⌘K) is also removed from the Search button. [1] [2] [3]New Interactive Features:
AlbumCardandTrackCardcomponents now include a "like" (heart) button in the top-right corner. Clicking toggles the liked state, visually updating the heart icon color. [1] [2] [3] [4] [5] [6]Dependency Updates:
baseline-browser-mappingpackage topackage.json, potentially for browser compatibility or feature detection.