Skip to content

nf-core-module-dev claude init attempt for hifiadapterfilt#11306

Open
vagkaratzas wants to merge 1 commit intomasterfrom
bots-claude-test-add-hifiadapterfilt
Open

nf-core-module-dev claude init attempt for hifiadapterfilt#11306
vagkaratzas wants to merge 1 commit intomasterfrom
bots-claude-test-add-hifiadapterfilt

Conversation

@vagkaratzas
Copy link
Copy Markdown
Contributor

@vagkaratzas vagkaratzas commented Apr 25, 2026

Imporved PR over Codex's version #11305
Compare to old, now closed PR: #7398

Used the nf-core-module-dev plugin on Claude.

Will probably need to rename to HIFIADAPTERFILT_HIFIADAPTERFILT, since the suite has more scripts (e.g., HIFIADAPTERFILT_HIFIADAPTERFILTFCS). @Ge94 to advise on this

PR checklist

Closes #7390

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@vagkaratzas vagkaratzas marked this pull request as draft April 25, 2026 09:20
@vagkaratzas vagkaratzas requested a review from Ge94 April 25, 2026 09:23
@vagkaratzas vagkaratzas marked this pull request as ready for review April 25, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: hifiadapterfilt

1 participant