Conversation
…ainer. Removed linkml validation which is more useful for interactive submission.
…e, distinguish from it sing submit_study is for raw-reads rather than assemblies, and remove references to mimicc.
…ript. Also renamed submit_rawreads_study to submit_study
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
vagkaratzas
left a comment
There was a problem hiding this comment.
Left a round of quick-through comments
…o one, trialling sanitizeOutput for test snapshot.
…puts that have been removed previously
| @@ -0,0 +1,774 @@ | |||
| #!/usr/bin/env python3 | |||
| """Submit studies to ENA via the Webin drop-box XML submission service. | |||
There was a problem hiding this comment.
Sorry about this 100 line docstring, I needed to show somewhere input file examples, because there is a lot of options and they are not documented anywhere. Even infering from the code what format is required is complicated
cc29a3e to
bbd8305
Compare
mberacochea
left a comment
There was a problem hiding this comment.
Thanks @ochkalova .. I gave it a quick read, and left some tiny comments.
I think we should do another round of cleaning, the python script still does stuff that I'm not sure is relevant for this project.
ochkalova
left a comment
There was a problem hiding this comment.
I tried to clean everything a bit, still some things left to do, but looks good enough to merge
Requested edits cannot be performed in this PR because require merge to more recent branch with bugfixes
Replace registerstudy with new python script that is general to all ENA studies.
For issue: #30
Update from @ochkalova
What was done in this PR:
registerstudyregisterstudymodule--study_metadata, schema updatedlibraryandena_raw_reads_study_accessionused by previous version ofregisterstudymagsandmetagenomic_assembliesthat register studyassemblysubmitandgenomesubmitupdated to useregisterstudyMinor changes:
TODOs:
--hold-untilto pipeline params