Conversation
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.5.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
|
@nf-core-bot fix linting |
georgiakes
left a comment
There was a problem hiding this comment.
Looks good overall. Just 2 things I wanted to flag—let me know if these should be addressed now or are planned for a follow-up:
-
Replace all
Channelfactories withchannel- Currently we've only updated the version channels and input channels declared at the top of the script. -
Remove version channels for subworkflows with only nf-core modules - Since the modules have the topics channel we do not need a versions channel
|
Yes, actually my overall plan is to get 1&2 until we release version 1.5. Yet, I realised first this PR getting too long and second some nf-core modules doesnt comply strict syntax for now. Therefore, I will update those nf-core modules and come back with part 2 to complete 1&2. Thanks for the overview @georgiakes ! |
|
Okay then! We follow up with these changes on part 2 :) |
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).