Merged
Conversation
Enable read & write block for iOS MIFARE Classic, Updated readme
Fix: NFC Handler dead thread issue on Android SDK 35
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Harry Chen <i@harrychen.xyz>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR releases version 3.6.1 of the flutter_nfc_kit package, focusing on modernizing the web interop layer to support WASM compilation, adding iOS MIFARE block read/write support, improving Android robustness, and updating build tools.
Key Changes
- Migrated web layer from deprecated
dart:js_utilto newdart:js_interopAPIs for WASM support - Added MIFARE Classic/Ultralight read/write block support for iOS platform
- Enhanced Android NFC handler thread management and fixed null pointer exception in IsoDep API
- Updated build tools: Gradle 9.2.1, AGP 8.13.0, Kotlin 2.2.21, and lowered minSdkVersion to 24
Reviewed changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| pubspec.yaml | Bumped version to 3.6.1, updated dependencies (ndef ^0.4.0, lints ^6.0.0), added web and universal_platform packages |
| lib/webusb_interop.dart | Refactored to use new dart:js_interop APIs, replacing dart:js_util with type-safe JS interop methods |
| lib/flutter_nfc_kit_web.dart | Updated to use package:web instead of dart:html, migrated to new js_interop APIs |
| lib/flutter_nfc_kit.dart | Added universal_platform dependency, added platform check for tagStream to return empty stream on non-Android platforms, added documentation about Samsung devices |
| ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift | Added MIFARE tag support for readBlock (0x30 command) and writeBlock (0xA2 command) operations |
| example/web/index.html | Modernized HTML template, removed service worker script, updated to use flutter_bootstrap_js |
| example/pubspec.yaml | Updated ndef dependency to ^0.4.0 |
| example/pubspec.lock | Updated transitive dependencies to reflect new package versions |
| example/lib/main.dart | Fixed formatting in tag info display string (added missing space) |
| example/android/gradle/wrapper/gradle-wrapper.properties | Updated Gradle wrapper to 9.2.1-bin |
| example/android/gradle.properties | Increased JVM memory, updated AGP to 8.13.0 and Kotlin to 2.2.21 |
| example/android/app/build.gradle | Lowered minSdkVersion from 26 to 24 |
| android/src/main/kotlin/im/nfc/flutter_nfc_kit/FlutterNfcKitPlugin.kt | Added handler thread lifecycle check and resurrection logic, added null-safety handling for IsoDep.historicalBytes |
| android/gradle/wrapper/gradle-wrapper.properties | Updated Gradle wrapper to 9.2.1-bin |
| android/gradle.properties | Increased JVM memory, updated AGP to 8.13.0 and Kotlin to 2.2.21 |
| android/build.gradle | Lowered minSdkVersion from 26 to 24 |
| README.md | Fixed typo (ISO 15963 → 15693), updated MIFARE capabilities description |
| CHANGELOG.md | Added 3.6.1 release notes documenting all changes |
| .github/workflows/test.yml | Added new test workflow with format checking, analysis, and pana scoring |
| .github/workflows/publish.yaml | Updated to use actions/checkout@v6 and flutter-actions/setup-flutter@v4, removed hardcoded Flutter version |
| .github/workflows/example-app.yml | Refactored to build both APK and iOS targets in a matrix strategy, updated to v5/v6 actions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift
Outdated
Show resolved
Hide resolved
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift
Outdated
Show resolved
Hide resolved
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift
Outdated
Show resolved
Hide resolved
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift
Outdated
Show resolved
Hide resolved
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift
Outdated
Show resolved
Hide resolved
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift
Outdated
Show resolved
Hide resolved
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift
Outdated
Show resolved
Hide resolved
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift
Outdated
Show resolved
Hide resolved
ios/flutter_nfc_kit/Sources/flutter_nfc_kit/FlutterNfcKitPlugin.swift
Outdated
Show resolved
Hide resolved
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
android/src/main/kotlin/im/nfc/flutter_nfc_kit/FlutterNfcKitPlugin.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Shengqi Chen <harry-chen@outlook.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 20 out of 21 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.