fix: use dialect-specific issue list LIKE escape#100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix issue-list
title_prefixSQL generation for MySQL/TiDB by using the existing dialect-specific LIKE escape clause helper instead of hard-coding the non-MySQL escape literal.The public CI failure was in the REST aggregate issue-list filter path, where TiDB rejected a generated
ESCAPE '\'clause. This updates the issue-list query builder to receive the active GORM database so it can emit the MySQL/TiDB form, and adds builder coverage for both issue and pull request title filters.Tracking
N/A
Tests
git diff --checkgo test ./internal/service -run 'TestBuildIssueListPageQueryUsesMySQLLikeEscapeClause|TestWikiSearchLikeEscapeClauseByDialect'go test ./internal/rest -run '^$'Local note: attempted to run the TiDB-backed REST reproduction locally, but the local TiDB playground failed to start on this machine. PR CI should cover the full REST unit suite.
Risks / Reviewer Notes
Low risk. The change only alters the SQL escape clause used by
title_prefixissue-list filters; non-MySQL dialects keep the existing fallback clause.SSOT Drift Prevention Checklist
docs/architecture.mdordocs/module-contracts.mddocs/test-strategy.mddocs/ci.md