Agilent 34401A Driver#1076
Draft
timp3289 wants to merge 2 commits into
Draft
Conversation
Collaborator
|
Hi, can you update this to apply cleanly to latest scopehal? |
Make SCPISocketTransport::SetTimeouts() a method of base class SCPITransport and implement it for SCPIUARTTransport Provide a base implementation which emits a warning that it is unimplemented Bump corresponding xptools version to support UART update (at least on Windows)
… 34401A over UART
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Andrew,
This PR is for a basic driver for the Agilent 34401A 6.5-digit DMM
Supported:
Not supported:
Tested:
Supporting changes:
I'm unsure of how UART timeouts work on unix, this may prevent proper operation as several commands take a long time to respond. If timeouts are very long (>2s) or infinite by default, this should be OK.
This PR relies on updating xptools:
ngscopeclient/xptools#39