Adding client.vi to manually test grpc feature#512
Open
Danus-NI wants to merge 12 commits into
Open
Conversation
added 6 commits
May 27, 2026 16:47
yash-ni
self-requested a review
June 4, 2026 19:37
yash-ni
reviewed
Jun 4, 2026
jasonmreding
reviewed
Jun 4, 2026
yash-ni
self-requested a review
June 8, 2026 20:15
yash-ni
approved these changes
Jun 8, 2026
jasonmreding
approved these changes
Jun 30, 2026
jasonmreding
left a comment
Collaborator
There was a problem hiding this comment.
From a code style perspective:
- The diagram wiring is a bit messy in spots. Try to maintain parallel wires without bends where possible. When not possible, try to maintain the minimal number of wire bends for a given wire. For example, try to avoid this sort of thing.
- Do not use the icon view for controls/indicators on the block diagram. I recommend you uncheck the "Place front panel terminals as icons" in the options dialog.
The remainder of the client VIs are a bit difficult to provide feedback on yet as nothing references them yet. For example, I suspect having all of the client VIs in the same folder as the server without any consistent naming scheme will be inconvenient when you attempt to modify the test suite scripts to copy them into the generated code in a generic fashion. However, I guess some of this feedback can be deferred until those changes come along.
Collaborator
|
BTW, these changes seem to be causing the build_release_artifacts pipeline stage to timeout/fail. I haven't tried to investigate why. |
Author
|
I have updated the messy wiring section as suggested: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Modification done to fix Main_CLIWrapper:

Added
To word integer:Added client.vi to manually run and test the grpc labview client - labview server connection.


Screentshops of the vis:
Helloworld:
all-datatypes-oneof:


enum-oneof:


message-oneof:


multiplie-field-oneof:


nested-oneof:


sibline-oneof:


simple-oneof:


enum-streaming:
2.server streaming:


oneof-streaming: