Skip to content

Adding client.vi to manually test grpc feature#512

Open
Danus-NI wants to merge 12 commits into
ni:masterfrom
Danus-NI:grpc-manual-test
Open

Adding client.vi to manually test grpc feature#512
Danus-NI wants to merge 12 commits into
ni:masterfrom
Danus-NI:grpc-manual-test

Conversation

@Danus-NI

@Danus-NI Danus-NI commented May 27, 2026

Copy link
Copy Markdown

Modification done to fix Main_CLIWrapper:
Added To word integer:
image

Added client.vi to manually run and test the grpc labview client - labview server connection.
Screentshops of the vis:
Helloworld:
image
image

all-datatypes-oneof:
image
image

enum-oneof:
image
image

message-oneof:
image
image

multiplie-field-oneof:
image
image

nested-oneof:
image
image

sibline-oneof:
image
image

simple-oneof:
image
image

enum-streaming:

  1. clientstreaming
image image

2.server streaming:
image
image

oneof-streaming:

  1. client streaming
image image
  1. server streaming
image image

@yash-ni
yash-ni self-requested a review June 4, 2026 19:37
Comment thread tests/New_ATS/pylib/testlist.json Outdated
Comment thread tests/New_ATS/Main_CLIWrapper.vi
@yash-ni
yash-ni self-requested a review June 8, 2026 20:15
@Danus-NI
Danus-NI requested a review from jasonmreding June 23, 2026 04:51

@jasonmreding jasonmreding left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a code style perspective:

  • The diagram wiring is a bit messy in spots. Try to maintain parallel wires without bends where possible. When not possible, try to maintain the minimal number of wire bends for a given wire. For example, try to avoid this sort of thing.
Image
  • Do not use the icon view for controls/indicators on the block diagram. I recommend you uncheck the "Place front panel terminals as icons" in the options dialog.
Image

The remainder of the client VIs are a bit difficult to provide feedback on yet as nothing references them yet. For example, I suspect having all of the client VIs in the same folder as the server without any consistent naming scheme will be inconvenient when you attempt to modify the test suite scripts to copy them into the generated code in a generic fashion. However, I guess some of this feedback can be deferred until those changes come along.

@jasonmreding

Copy link
Copy Markdown
Collaborator

BTW, these changes seem to be causing the build_release_artifacts pipeline stage to timeout/fail. I haven't tried to investigate why.

@Danus-NI

Danus-NI commented Jul 8, 2026

Copy link
Copy Markdown
Author

I have updated the messy wiring section as suggested:
image
@jasonmreding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants